On 1/2/26 23:13, Philippe Mathieu-Daudé wrote:
From: Vladimir Sementsov-Ogievskiy <[email protected]>Test that the fix in commit 20aa05edc2c ("util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic") make sense. To not break compilation when we build without 'block', move hexdump.c out of "if have_block" in meson.build. Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- v6: - mention commit 20aa05edc2c in desc - wrap long lines for checkpatch.pl - use g_file_open_tmp() --- tests/unit/test-cutils.c | 67 ++++++++++++++++++++++++++++++++++++++++ util/meson.build | 2 +- 2 files changed, 68 insertions(+), 1 deletion(-)
+ /* We expect proper alignment of "s is" part on the second line */ + static const char *expected = + "test: 0000: 48 65 6c 6c 6f 20 57 6f 72 6c 64 21 20 54 68 69 " + "Hello World! Thi\n" + "test: 0010: 73 20 69 73 20 " + "s is \n";
BTW I chose to ignore this checkpatch.pl error: ERROR: unnecessary whitespace before a quoted newline #90: FILE: tests/unit/test-cutils.c:3686: + "s is \n";
