On Thu, Jun 14, 2012 at 08:18:10AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 11:13 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > > > The previous patches fixed almost all the inconsistent names used > > > for PCIDevice in msix.c, fix the one remaining transgression. > > > > > > Signed-off-by: Alex Williamson <alex.william...@redhat.com> > > > > Except, would be better to first rename parameters and > > do other mechanical changes, and then apply your diff > > on top. > > > > As it is the patch looks like it rewrites everything while > > it could be a very small one. > > You're welcome for trying to add consistency, sorry I pointed it out.
No problem with this patch itself though. > > > --- > > > > > > hw/msix.h | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/hw/msix.h b/hw/msix.h > > > index 14b1a2e..1786e27 100644 > > > --- a/hw/msix.h > > > +++ b/hw/msix.h > > > @@ -11,8 +11,7 @@ int msix_init(PCIDevice *dev, unsigned short nentries, > > > int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries, > > > uint8_t bar_nr); > > > > > > -void msix_write_config(PCIDevice *pci_dev, uint32_t address, > > > - uint32_t val, int len); > > > +void msix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, > > > int len); > > > > > > void msix_uninit(PCIDevice *dev, MemoryRegion *table_bar, > > > MemoryRegion *pba_bar); > >
