Michael Tokarev <[email protected]> writes: > Prior discussion is at > https://lore.kernel.org/qemu-devel/[email protected]/ > > In short: when adding unlink() before bind() for unix socket > in gdbstub/user.c, a previous patch introduced dependency of > linux-user binaries on qemu-sockets.c, which is more problematic > for usually-static binaries. The monitor_get_fd stub which were > also needed is another example why this might not be the right > approach. > > This patchset reverts the previous commit (with fixes for current > code), and adds just a single unlink() to the original code which > handled unix sockets directly.
This isn't applying cleanly for me. Could you re-base please? > > Michael Tokarev (2): > Revert "gdbstub: Try unlinking the unix socket before binding" > gdbstub: unlink the unix socket before bind() > > gdbstub/user.c | 30 +++++++++++++++++++++++++++--- > stubs/meson.build | 2 -- > util/meson.build | 2 -- > 3 files changed, 27 insertions(+), 7 deletions(-) -- Alex Bennée Virtualisation Tech Lead @ Linaro
