Re: [PATCH v1 3/7] hw/pci-host/aspeed_pcie: Drop AST2600 RC_H root-bus remap and bus-nr property

[Cédric Le Goater]

On 1/27/26 04:23, Jamin Lin via qemu development wrote:

The original AST2600 PCIe design supported both RC_L and RC_H, using root bus
number 0 for RC_L and 0x80 for RC_H. In that model, the root port appeared as
80:08.0 and QEMU carried a "bus-nr" property plus a config-space bus remap to
translate bus 0x80 to bus 0x00 for PCI enumeration.

Linux mainline has since dropped RC_L support and updated the RC_H root bus

Was PCI support for the Aspeed SoC merged in mainline  ?

Thanks,

C.

number to start at 0. The root port is now enumerated as 00:08.0, matching the
default QEMU PCIe subsystem root bus numbering.

Remove the bus number setting and the AST2600 bus remap logic, and drop the
corresponding "bus-nr"/rc_bus_nr fields and property plumbing. QEMU now relies
on the default root bus 0 behavior.

Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>
---
  include/hw/pci-host/aspeed_pcie.h |  2 --
  hw/pci-host/aspeed_pcie.c         | 19 +------------------
  2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/include/hw/pci-host/aspeed_pcie.h 
b/include/hw/pci-host/aspeed_pcie.h
index fde5816ea3..143b356591 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -69,7 +69,6 @@ struct AspeedPCIERcState {
      uint64_t dram_base;
      uint32_t msi_addr;
      uint32_t rp_addr;
-    uint32_t bus_nr;
      char name[16];
      qemu_irq irq;

@@ -102,7 +101,6 @@ struct AspeedPCIECfgClass { uint32_t rc_msi_addr;

      uint32_t rc_rp_addr;
-    uint64_t rc_bus_nr;
      uint64_t nr_regs;
      bool rc_has_rd;
  };
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 4fdda95939..4f896f855c 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -268,7 +268,7 @@ static const char 
*aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
      AspeedPCIECfgState *cfg =
             container_of(rc, AspeedPCIECfgState, rc);

- snprintf(rc->name, sizeof(rc->name), "%04x:%02x", cfg->id, rc->bus_nr);

+    snprintf(rc->name, sizeof(rc->name), "%04x:00", cfg->id);

return rc->name;

  }
@@ -283,7 +283,6 @@ static void aspeed_pcie_rc_instance_init(Object *obj)
  }

static const Property aspeed_pcie_rc_props[] = {

-    DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
      DEFINE_PROP_UINT32("rp-addr", AspeedPCIERcState, rp_addr, 0),
      DEFINE_PROP_UINT32("msi-addr", AspeedPCIERcState, msi_addr, 0),
      DEFINE_PROP_UINT64("dram-base", AspeedPCIERcState, dram_base, 0),
@@ -490,17 +489,6 @@ static void aspeed_pcie_cfg_readwrite(AspeedPCIECfgState 
*s,
      offset = cfg_addr & 0xffc;

pci = PCI_HOST_BRIDGE(rc);

-
-    /*
-     * On the AST2600, the RC_H bus number range from 0x80 to 0xFF, with the
-     * root device and root port assigned to bus 0x80 instead of the standard
-     * 0x00. To allow the PCI subsystem to correctly discover devices on the
-     * root bus, bus 0x80 is remapped to 0x00.
-     */
-    if (bus == rc->bus_nr) {
-        bus = 0;
-    }
-
      pdev = pci_find_device(pci->bus, bus, devfn);
      if (!pdev) {
          s->regs[desc->rdata_reg] = ~0;
@@ -650,9 +638,6 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, Error 
**errp)
                            apc->nr_regs << 2);
      sysbus_init_mmio(sbd, &s->mmio);

- object_property_set_int(OBJECT(&s->rc), "bus-nr",

-                            apc->rc_bus_nr,
-                            &error_abort);
      object_property_set_int(OBJECT(&s->rc), "rp-addr",
                              apc->rc_rp_addr,
                              &error_abort);
@@ -691,7 +676,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, 
const void *data)
      apc->reg_map = &aspeed_regmap;
      apc->nr_regs = 0x100 >> 2;
      apc->rc_msi_addr = 0x1e77005C;
-    apc->rc_bus_nr = 0x80;
      apc->rc_rp_addr = PCI_DEVFN(8, 0);
  }

@@ -811,7 +795,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,

      apc->reg_map = &aspeed_2700_regmap;
      apc->nr_regs = 0x100 >> 2;
      apc->rc_msi_addr = 0x000000F0;
-    apc->rc_bus_nr = 0;
      apc->rc_rp_addr = PCI_DEVFN(0, 0);
  }