On 1/27/26 9:10 AM, Pierrick Bouvier wrote:
On 1/27/26 1:28 AM, Alex Bennée wrote:
Richard Henderson <[email protected]> writes:
On 1/27/26 10:50, Alex Bennée wrote:
I think it was broken by 4203ea0247f (gitlab-ci: Add build tests for
wasm64) because we base the tests of the existence of dockerfiles and it
now generates multiple targets.
Do we actually use the wasm32 stuff anymore? Maybe we can just
rename it?
All of the wasm32 stuff is supposed to be gone.
I think [email protected] should fix it,
but I need to re-read how to trigger the weekly build on my test branch
to test it.
r~
What if docker-verify was depending on building the container locally
instead? It would allow to have a self-contained command, that works the
same in local, or in CI, without any yaml dependencies.
With current approach, it's tricky to reproduce locally as it depends on
global gitlab registry, while we are just trying to see if images is
buildable from scratch or not.
The fact it's hard to guess how to test such a change exposes that there
is a problem to reproduce this, even for the original author.
As well, docker or podman already have inspect command builtin, so I'm
not sure what is the added value of skopeo here.
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 38467cca610..c280467aa8d 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -50,11 +50,11 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker
"BUILD", $*)
# General rule for inspecting registry images.
-docker-verify-%: $(DOCKER_FILES_DIR)/%.docker
+docker-verify-%: docker-image-% $(DOCKER_FILES_DIR)/%.docker
$(call quiet-command, \
- skopeo inspect \
+ $(RUNC) inspect \
--format '{{.Created}}' \
- docker://$(DOCKER_REGISTRY)/qemu/$* \
+ qemu/$* \
$(if $V,,> /dev/null),\
"VERIFY", $*)
