Peter Xu <[email protected]> writes: > CI: https://gitlab.com/peterx/qemu/-/pipelines/2287309287 > > v2: > - Collected r-bs / a-bs > - Patch 2: update comment for possible sequence of notifies [Fabiano] > > v1: https://lore.kernel.org/r/[email protected] > > Two major goals for this small series: > > - Fix postcopy issue where DONE and FAILED notifiers will be invoked twice > > - Move FAILED notifier to be before vm_start() if the failure happens > during switchover (where we will stop the VM first) > > The 2nd goal will be needed by Stefan's ongoing work on block persistent > reservations, where a fallback should be required on src to happen before > vm_start(). Instead of introducing another FAILED_BEFORE_START, this > patchset should make FAILED work instead. > > Patch 1 adds a tracepoint for me to verify this fix. > > Patch 2-3 are the real changes of above two. > > Patch 3-4 are some cleanups alone the context that we can do, hence > attached at the end. > > More details in commit logs individually. Comments welcomed, thanks. > > Peter Xu (5): > migration: Add a tracepoint for invoking migration notifiers > migration: Fix double notification of DONE/FAIL for postcopy > migration: Notify migration FAILED before starting VM > migration: Drop explicit block activation in postcopy fail path > migration: Rename MIG_EVENT_PRECOPY_* to MIG_EVENT_* > > include/migration/misc.h | 20 ++++++++++++-------- > hw/intc/arm_gicv3_kvm.c | 2 +- > hw/net/virtio-net.c | 4 ++-- > hw/vfio/cpr-legacy.c | 2 +- > hw/vfio/cpr.c | 8 ++++---- > hw/vfio/migration.c | 4 ++-- > migration/cpr-exec.c | 6 +++--- > migration/migration.c | 29 ++++++++++++++++++++--------- > net/vhost-vdpa.c | 4 ++-- > ui/spice-core.c | 7 ++++--- > migration/trace-events | 1 + > 11 files changed, 52 insertions(+), 35 deletions(-)
Queued, let me know if you want to change patch 2.
