Our documentation says that memory regions are automatically freed when the owner dies and the reference counting to do this is also implemented. However this relies on the QOM free funtion that can only be set by creating objects with object_new but memory API only provides constructors that call object_initialize which clears the free function that prevents QOM to manage the memory region lifetime. Implement corresponding memory_region_new_* functions that do the same as the memory_region_init_* functions but create the memory region with object_new so the lifetime can be automatically managed by QOM as documented. The memory_region_init functions are kept because they are useful for memory regions embedded in other object or managed externally and not by QOM for some reason.
v2: - rebase on master - update documentation - use these function to fix some leaks (there may be more, e.g. in hw/pci-host/bonito but I leave that for later and/or others) BALATON Zoltan (10): memory: Add internal memory_region_set_ops helper function memory: Factor out common ram region initialization memory: Factor out more common ram region initialization memory: Shorten memory_region_init_rom_nomigrate memory: Add internal memory_region_register_ram function memory: Add memory_region_new* functions memory: Update documentation for memory_region_new*() hw/ide/sii3112: Use memory_region_new to avoid leaking regions hw/pci-host/articia: Map PCI memory windows in realize hw/pci-host/articia: Add variable for common type cast docs/devel/memory.rst | 21 +- hw/ide/sii3112.c | 30 +-- hw/pci-host/articia.c | 22 +- hw/ppc/amigaone.c | 28 +-- hw/ppc/pegasos.c | 13 -- include/system/memory.h | 360 ++++++++++++++++++++++++++++++ system/memory.c | 484 +++++++++++++++++++++++++--------------- 7 files changed, 713 insertions(+), 245 deletions(-) -- 2.41.3
