On Wed, 7 Jan 2026 at 22:45, Peter Xu <[email protected]> wrote: > On Wed, Jan 07, 2026 at 05:07:40PM +0530, Prasad Pandit wrote: > > On Wed, 7 Jan 2026 at 02:04, Peter Xu <[email protected]> wrote: > > > The parameter can be instead passed into the function. > > > > * It'll help to include - why? pass the parameter instead. > > I want to remove special and unnecessary fields in MigrateCommon struct. > > I'll add a sentence when repost. ... > > * To keep it consistent, maybe we can call the variable 'stage' as above? > > Personally I prefer fail_stage, e.g. fail_stage=NONE means it never fails. > stage==NONE is less clear.
* Let's make it fail_stage in both places then? Reviewed-by: Prasad Pandit <[email protected]> Thank you. --- - Prasad
