Hi On Sat, Nov 29, 2025 at 5:44 PM Vladimir Sementsov-Ogievskiy < [email protected]> wrote:
> Hi all. > > Here is a cleanup for chardev code: > > - improve naming > - add boolean return for some errp-functions > - simplify open() API > > Vladimir Sementsov-Ogievskiy (8): > chardev: ChardevClass: consistent naming for handlers > chardev: consistent naming for ChardevClass handlers implementations > chardev: .chr_open(): drop be_opened parameter > chardev: .chr_open(): add boolean return value > chardev/char-pty: store pty_name into PtyChardev state > chardev: introduce .chr_get_pty_name() handler > chardev: rework filename handling > chardev/char: qemu_char_open(): add return value > Except 3rd patch, lgtm. (it conflicts a bit with "[PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses <https://patchew.org/QEMU/[email protected]/>" though, I guess I will handle that) > > chardev/baum.c | 12 ++-- > chardev/char-console.c | 10 ++-- > chardev/char-fe.c | 8 +-- > chardev/char-file.c | 26 ++++---- > chardev/char-hub.c | 27 ++++----- > chardev/char-mux.c | 30 ++++++---- > chardev/char-null.c | 9 +-- > chardev/char-parallel.c | 41 ++++++------- > chardev/char-pipe.c | 30 +++++----- > chardev/char-pty.c | 52 ++++++++-------- > chardev/char-ringbuf.c | 20 ++++--- > chardev/char-serial.c | 39 ++++++------ > chardev/char-socket.c | 59 +++++++++---------- > chardev/char-stdio.c | 30 +++++----- > chardev/char-udp.c | 16 ++--- > chardev/char-win-stdio.c | 25 ++++---- > chardev/char.c | 51 ++++++++-------- > chardev/msmouse.c | 13 ++-- > chardev/spice.c | 50 ++++++++-------- > chardev/wctablet.c | 10 ++-- > gdbstub/system.c | 12 ++-- > hw/char/xen_console.c | 7 ++- > hw/misc/ivshmem-pci.c | 4 +- > include/chardev/char.h | 37 +++++++++--- > .../codeconverter/test_regexps.py | 2 +- > ui/console-vc.c | 12 ++-- > ui/dbus-chardev.c | 16 +++-- > ui/dbus.c | 4 +- > ui/gtk.c | 14 ++--- > ui/spice-app.c | 18 +++--- > ui/vdagent.c | 17 +++--- > 31 files changed, 354 insertions(+), 347 deletions(-) > > -- > 2.48.1 > >
