Virglrender got a new API that allows mapping host blobs at a given memory address using MAP_FIXED mmap flag [1]. Usage of this new API brings major performance and stability improvement for venus and drm native contexts, see commit message of the RFC patch for details.
Sending early to collect review feeback and have patch prepared by the time new version of libvirglrenderer will be released with the stabilized API. [1] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1374 Based-on: [email protected] Changelog: v5: - Switched to use error_setg_errno() for qemu_ram_mmap() error handling, as was suggested Akihiko Odaki. - Added r-b from Alex Bennée to the first patch. - Moved hostmem mapping offset validation to upper function as was suggested by Alex Bennée. - Dropped all patches and changes that made funcs to return -1 since it was rejected by Alex Bennée. Refactoring can be done later on in a separate patchset. - Extended clarifying comment of virtio_gpu_virgl_reset(). v4: - Addressed v3 review comments from Akihiko Odaki. - Dropped patch making resource_unmap() error reported as a host failure instead of guest and added patch improving resource_map_blob() error reporting. - Re-added CONFIG_WIN32 checks. - Added clarifying comment to virtio_gpu_virgl_reset() RE unsupported context restoring. v3: - Addressed v2 review comments from Akihiko Odaki. - Droped check for CONFIG_WIN32. My current understanding that MAP_FIXED is supported by Cygwin. - Added new patches resetting virgl resources, validating hostmem offset and improving error-handlings. - Added r-b from Akihiko Odaki to the frist patch and t-b from Yiwei Zhang to the map_fixed patch. v2: - Addressed v1 review comments from Akihiko Odaki - Added patch that removes unnecessary memory_region_set_enabled(), suggested by Akihiko Odaki Dmitry Osipenko (4): virtio-gpu: Remove superfluous memory_region_set_enabled() virtio-gpu: Validate hostmem mapping offset virtio-gpu: Destroy virgl resources on virtio-gpu reset virtio-gpu: Support mapping hostmem blobs with map_fixed hw/display/virtio-gpu-gl.c | 46 +++++++++- hw/display/virtio-gpu-virgl.c | 158 ++++++++++++++++++++++++++++----- include/hw/virtio/virtio-gpu.h | 8 +- 3 files changed, 185 insertions(+), 27 deletions(-) -- 2.51.1
