On Fri, May 09, 2025 at 06:04:11PM +0200, Igor Mammedov wrote:
> Date: Fri, 9 May 2025 18:04:11 +0200
> From: Igor Mammedov <[email protected]>
> Subject: Re: [PATCH v4 10/27] hw/i386/pc: Remove linuxboot.bin
> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu)
> 
> On Thu,  8 May 2025 15:35:33 +0200
> Philippe Mathieu-Daudé <[email protected]> wrote:
> 
> > All PC machines now use the linuxboot_dma.bin binary,
> > we can remove the non-DMA version (linuxboot.bin).
> > 
> > Suggested-by: Thomas Huth <[email protected]>
> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> > ---
> >  hw/i386/pc.c                  |   3 +-
 
(After a long interval, more of a note.)

> linuxboot.bin is referenced in a few more files:
> 
> hw/i386/x86-common.c:    option_rom[nb_option_roms].name = "linuxboot.bin";

this case is removed in previous patch (which considerred x86 machines
all have DMA enabled).

> hw/nvram/fw_cfg.c:    { "genroms/linuxboot.bin", 60 },

this case is removed in commit 6160ce208419 ("hw/nvram/fw_cfg: Remove
legacy FW_CFG_ORDER_OVERRIDE").

Regards,
Zhao


Reply via email to