On Wed, Nov 26, 2025 at 12:46:40PM +0100, Markus Armbruster wrote: > Cédric Le Goater <[email protected]> writes: > > > On 11/26/25 09:19, Cédric Le Goater wrote: > >> On 11/25/25 17:15, Peter Xu wrote: > >>> On Tue, Nov 25, 2025 at 12:46:01PM +0100, Markus Armbruster wrote: > > [...] > > On the review and merging of commit 18eb55546a5 (error: define > g_autoptr() cleanup function for the Error type): > > >>>> I missed it. Not he submitter's fault; it was cc'ed to me. > >>> > >>> If someone to blame, it's the reviewer. > >> At end, I was the one who merged this stuff. My bad. > >> > >> I felt confident at the time, as it was only a single-line change reviewed > >> by a subsystem maintainer and the patch was large enough that this didn't > > > > s/patch/series/ makes more sense. > > > > Sorry for the noise. > > > C. > > > > > >> raise my attention. > >> > >> But it should have been treated with greater caution, global features must > >> be introduced together with concrete usage proposals. I think this would > >> have raised some unconscious red flags. > >> Thanks, > >> C. > > Don't worry about it! From my point of view, the process worked okay. > A big series got reviewed by maintainers, except for one little patch > touching another subsystem, where that subsystem's maintainer (me) > remained silent. The series was then merged without further delay. > > Would I have appreciate a timely nudge on that little patch? Sure. Is > not nudging me a failure of sorts? Nope.
The other thing that plays in here is that we actively encourage use of g_autoptr everywhere. It is very unusual for "Error" to be a type that does NOT want g_autoptr, and thus the mistake is very much on the cards. I've proposed it before myself & Markus caught it. I also caught one other proposals to add it since my attempt. This third time it slipped through review. I expect we'll see a 4th attempt to add it at some point. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
