Cédric Le Goater <[email protected]> writes:
> On 11/25/25 21:46, Peter Xu wrote:
>> This reverts commit 18eb55546a54e443d94a4c49286348176ad4b00a. Discussion
>> can be seen at:
>> https://lore.kernel.org/r/[email protected]
>> Cc: Maciej S. Szmigiero <[email protected]>
>> Cc: Cédric Le Goater <[email protected]>
>> Signed-off-by: Peter Xu <[email protected]>
>> ---
>> include/qapi/error.h | 2 --
>> 1 file changed, 2 deletions(-)
>> diff --git a/include/qapi/error.h b/include/qapi/error.h
>> index b16c6303f8..f3ce4a4a2d 100644
>> --- a/include/qapi/error.h
>> +++ b/include/qapi/error.h
>> @@ -437,8 +437,6 @@ Error *error_copy(const Error *err);
>> */
>> void error_free(Error *err);
>>
>> -G_DEFINE_AUTOPTR_CLEANUP_FUNC(Error, error_free)
>> -
>> /*
>> * Convenience function to assert that *@errp is set, then silently free it.
>> */
>
> Is that related to CID 1643463 issue ?
g_autoptr(Error) is a bad idea, as discussed in
Subject: g_autoptr(Error) (was: [PATCH] migration: Fix double-free on error
path)
Date: Tue, 25 Nov 2025 08:40:07 +0100
Message-ID: <[email protected]>
We have three instances of g_autoptr(Error) in master. CID 1643463 made
me see them.
One is removed by my fix to CID 1643463:
Subject: [PATCH] migration: Fix double-free on error path
Date: Tue, 25 Nov 2025 08:05:54 +0100
Message-ID: <[email protected]>
The remaining two get removed in PATCH 1. This patch deletes the code
that makes g_autoptr(Error) work.
> anyhow,
>
>
> Reviewed-by: Cédric Le Goater <[email protected]>
Thank you!
