Hi Daniel,
> Did this patch code directly evolve from Petros' patch linked at [0], or
> was the latter merely inspiration and this a fresh implementation ?
> [...]
it's a direct follow-up with minor modifications and not a new implementation.
I'll change the sign-off lines accordingly in v2.
> FYI, use of g_alloca() is no longer permitted in QEMU code.
Thanks for pointing that out. I misread the coding style guide in that regard.
Will get rid of g_alloca() for v2.
>> int loader_exec(int fdexec, const char *filename, char **argv, char **envp,
>> struct image_info *infop, struct linux_binprm *bprm)
>> {
>> [...]
>> + retval = load_script_file(filename, bprm);
>>
>> If load_script_file() failed to open or read the filename, is
>> it correct to continue executing with this fallback ? Is there
>> a scenario where QEMU would be unable to open/read, but it be
>> none the less possible for it to work int his fallback ?
Will need to double-check on that.
Regards,
Moritz
