When there is no display device on qemu machine, and user only access qemu by remote vnc. At the same time user input `info vnc` by QMP, the qemu will abort.
To avoid the abort above, I add display device check, when query vnc info in qmp_query_vnc_servers(). Reviewed-by: Marc-AndréLureau <[email protected]> Signed-off-by: Alano Song <[email protected]> --- ui/vnc.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 0d499b208b..3a54a6d24b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -556,9 +556,15 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp) qmp_query_auth(vd->auth, vd->subauth, &info->auth, &info->vencrypt, &info->has_vencrypt); if (vd->dcl.con) { - dev = DEVICE(object_property_get_link(OBJECT(vd->dcl.con), - "device", &error_abort)); - info->display = g_strdup(dev->id); + Error *err = NULL; + Object *obj = object_property_get_link(OBJECT(vd->dcl.con), + "device", &err); + if (obj) { + dev = DEVICE(obj); + info->display = g_strdup(dev->id); + } else { + error_free(err); + } } if (vd->listener != NULL) { nsioc = qio_net_listener_nsioc(vd->listener); -- 2.43.0
