Re: [PATCH] migration: Fix double-free on error path

[Marc-André Lureau]

Hi

On Tue, Nov 25, 2025 at 11:06 AM Markus Armbruster <arm...@redhat.com> wrote:
>
> Fixes: ffaa1b50a879 (migration: Use warn_reportf_err() where appropriate)
> Resolves: Coverity CID 1643463
> Signed-off-by: Markus Armbruster <arm...@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>

> ---
>  migration/multifd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/multifd.c b/migration/multifd.c
> index 6210454838..3203dc98e1 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -450,7 +450,7 @@ static void multifd_send_set_error(Error *err)
>   */
>  static void migration_ioc_shutdown_gracefully(QIOChannel *ioc)
>  {
> -    g_autoptr(Error) local_err = NULL;
> +    Error *local_err = NULL;
>
>      if (!migration_has_failed(migrate_get_current()) &&
>          object_dynamic_cast((Object *)ioc, TYPE_QIO_CHANNEL_TLS)) {
> --
> 2.49.0
>

Maybe warn_reportf_err() should take a Error **err instead, and clear
it (and accept NULL values)


-- 
Marc-André Lureau