On Friday, 21 November 2025 19:32:14 CET Andrey Erokhin wrote: > On 21/11/2025 17:20, Christian Schoenebeck wrote: > > Andrey, just some minor issues from my side below: > > > > Git commit log message should not exceed 76 characters per line. > > TBH, I'm not used to sending patches by git, it was just an e-mail message, > not a commit message
NP. You can use whatever you want (git send-email, any standard email client, a script). However patches are automatically applied from this mailing list, so the leading sentences of your email *is* the git commit log message. > >> QEMU issues: > >> https://gitlab.com/qemu-project/qemu/-/issues/173 (from > >> https://bugs.launchpad.net/qemu/+bug/1831354) > >> https://gitlab.com/qemu-project/qemu/-/issues/3088 (dup of the first one) > > > > This should be: > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/173 > > Fixed in the attached patch. Or should I start a new [PATCH v2] thread? Please resend with [PATCH v2] in the subject. Patches should always be inline in the email, not as an attachment, and new versions should be top posted (i.e. not In-Reply-To v1 email). /Christian
