Re: [RFC v2 1/4] hw: vmapple: include missing headers

[Alexander Graf]

On 07.10.25 22:31, Mohamed Mediouni wrote:

Disablement by default led to:

../hw/vmapple/vmapple.c:276:39: error: use of undeclared identifier 
'GTIMER_VIRT'
   276 |         qdev_connect_gpio_out(cpudev, GTIMER_VIRT,
       |                                       ^
../hw/vmapple/vmapple.c:479:54: error: use of undeclared identifier 
'QEMU_PSCI_CONDUIT_HVC'
   479 |         object_property_set_int(cpu, "psci-conduit", 
QEMU_PSCI_CONDUIT_HVC,
       |                                                      ^
../hw/vmapple/vmapple.c:556:13: error: call to undeclared function 
'arm_build_mp_affinity'; ISO C99 and later do not support implicit function 
declarations [-Wimplicit-function-declaration]
   556 |             arm_build_mp_affinity(n, GICV3_TARGETLIST_BITS);
       |             ^
3 errors generated.

pretty quickly.

Signed-off-by: Mohamed Mediouni <moha...@unpredictable.fr>

This patch should be stand alone and not RFC.

Alex

---
  hw/vmapple/vmapple.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/vmapple/vmapple.c b/hw/vmapple/vmapple.c
index 16e6110b68..5928df4411 100644
--- a/hw/vmapple/vmapple.c
+++ b/hw/vmapple/vmapple.c
@@ -51,6 +51,8 @@
  #include "system/reset.h"
  #include "system/runstate.h"
  #include "system/system.h"
+#include "gtimer.h"
+#include "cpu.h"

struct VMAppleMachineState {

      MachineState parent;