Missing review: #12 (new) Since v2: - Dropped few patches - Do not rename @start -> @addr (rth)
Following a previous comment from Richard in [*], reduce "system/ram_addr.h" size by un-inlining a lot of huge functions that aren't really justified, and extract the API to the hew "system/physmem.h" header, after renaming the functions (removing the confusing 'cpu_' prefix). (I plan to eventually merge this myself due to the likelyness of conflicts). [*] https://lore.kernel.org/qemu-devel/[email protected]/ Philippe Mathieu-Daudé (18): system/ram_addr: Remove unnecessary 'exec/cpu-common.h' header accel/kvm: Include missing 'exec/target_page.h' header hw/s390x/s390-stattrib: Include missing 'exec/target_page.h' header hw/vfio/listener: Include missing 'exec/target_page.h' header target/arm/tcg/mte: Include missing 'exec/target_page.h' header hw: Remove unnecessary 'system/ram_addr.h' header system/physmem: Un-inline cpu_physical_memory_get_dirty_flag() system/physmem: Un-inline cpu_physical_memory_is_clean() system/physmem: Un-inline cpu_physical_memory_range_includes_clean() system/physmem: Un-inline cpu_physical_memory_set_dirty_flag() system/physmem: Un-inline cpu_physical_memory_set_dirty_range() system/physmem: Remove _WIN32 #ifdef'ry system/physmem: Un-inline cpu_physical_memory_set_dirty_lebitmap() system/physmem: Un-inline cpu_physical_memory_dirty_bits_cleared() system/physmem: Reduce cpu_physical_memory_clear_dirty_range() scope system/physmem: Reduce cpu_physical_memory_sync_dirty_bitmap() scope system/physmem: Drop 'cpu_' prefix in Physical Memory API system/physmem: Extract API out of 'system/ram_addr.h' header MAINTAINERS | 1 + include/system/physmem.h | 54 ++++ include/system/ram_addr.h | 413 ------------------------------ accel/kvm/kvm-all.c | 5 +- accel/tcg/cputlb.c | 13 +- hw/ppc/spapr.c | 1 - hw/ppc/spapr_caps.c | 1 - hw/ppc/spapr_pci.c | 1 - hw/remote/memory.c | 1 - hw/remote/proxy-memory-listener.c | 1 - hw/s390x/s390-stattrib-kvm.c | 2 +- hw/s390x/s390-stattrib.c | 2 +- hw/s390x/s390-virtio-ccw.c | 1 - hw/vfio/container-legacy.c | 10 +- hw/vfio/container.c | 5 +- hw/vfio/listener.c | 2 +- hw/vfio/spapr.c | 1 - hw/virtio/virtio-mem.c | 1 - migration/ram.c | 78 +++++- system/memory.c | 9 +- system/physmem.c | 322 ++++++++++++++++++++++- target/arm/tcg/mte_helper.c | 5 +- system/memory_ldst.c.inc | 2 +- tests/tsan/ignore.tsan | 4 +- 24 files changed, 475 insertions(+), 460 deletions(-) create mode 100644 include/system/physmem.h -- 2.51.0
