Il 30/05/2012 14:49, Eric Blake ha scritto: > On 05/30/2012 04:01 AM, Pavel Hrdina wrote: >> This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this >> code is not used >> in order that we use readline mode for '-qmp stdio'. >> >> Conflicts: >> >> qemu-char.c > > This is evidence that you've rebased locally
Note that if your workflow is rebase-heavy (mine is) you can use the prepare-commit-msg hook to comment out such lines. The sample hook already has the code (.git/hooks/prepare-commit-msg.sample). > As to the series itself, will readline mode add overhead? Libvirt wants > to use QMP monitor without the overhead of remembering issued commands, > and if the difference for turning on readline is significant, then it > needs to be an opt-in option and not the default. The patch should be a no-op unless you use -qmp stdio. Paolo
