On Wed, Sep 24, 2025 at 08:05:36AM +0000, Duan, Zhenzhong wrote:
> >uint64_t host_iommu_extract_quirks(enum iommu_hw_info_type,
> >VendorCaps *caps)
> >{
> > uint64_t quirks = 0;
> >
> >#if defined(CONFIG_VTD)
>
> I have applied all suggested change except CONFIG_VTD here as it's a device
> config and iommufd.c is device agnostic, it doesn't recognize CONFIG_VTD.
>
> ../backends/iommufd.c:419:13: error: attempt to use poisoned "CONFIG_VTD"
>
> I thought this is trivial and OK for not having CONFIG_VTD?
Hmm.. I didn't expect that. It seems that QEMU does encourage
moving all vendor specific code to vendor specific file :-/
Anyway, I think it's fine to drop the ifdef. The VTD type and
cap structure are defined in the shared uAPI header.
Nicolin
