It is too easy to mis-use tb_flush(). For instance, because of
the cpu argument, some parts assumed that it needed to call the
global flush function for every cpu. It is easy to forget that
the flush is not complete when the call returns: we have merely
queued work to the cpu run loop. So: remove tb_flush and expose
only the core as tb_flush__exclusive, to be used only when we
are already within an exclusive context.
In some cases (gdbstub, alpha, riscv, ppc spapr),
we can eliminate the need for tb_flush completely.
Changes for v3:
- Rename to tb_flush__exclusive_or_serial; retain the serial
check within, not updating to exclusive only.
- Rename the existing tb_flush to queue_tb_flush; retain the
sequence number check for duplicated flushes.
- Drop EXCP_TB_FLUSH.
- Improve buffer overflow flush when we're already serial.
- Other minor comment/review updates.
r~
Richard Henderson (10):
gdbstub: Remove tb_flush uses
target/alpha: Simplify call_pal implementation
target/riscv: Record misa_ext in TCGTBCPUState.cs_base
hw/ppc/spapr: Use tb_invalidate_phys_range in h_page_init
accel/tcg: Split out tb_flush__exclusive_or_serial
accel/tcg: Move post-load tb_flush to vm_change_state hook
plugins: Use tb_flush__exclusive_or_serial
linux-user: Split out begin_parallel_context
accel/tcg: Create queue_tb_flush from tb_flush
accel/tcg: Improve buffer overflow in tb_gen_code
include/exec/tb-flush.h | 30 ++++++++++++++--------
linux-user/user-internals.h | 16 ++++++++++++
target/alpha/helper.h | 1 -
accel/tcg/plugin-gen.c | 4 +--
accel/tcg/tb-maint.c | 50 +++++++++++++++++++++----------------
accel/tcg/tcg-all.c | 21 ++++++++++++++++
accel/tcg/translate-all.c | 6 ++++-
gdbstub/system.c | 5 ----
gdbstub/user.c | 3 ---
hw/core/cpu-system.c | 9 -------
hw/ppc/spapr_hcall.c | 4 +--
linux-user/alpha/cpu_loop.c | 5 ----
linux-user/mmap.c | 13 ++--------
linux-user/syscall.c | 7 +-----
plugins/core.c | 6 ++---
plugins/loader.c | 3 +--
target/alpha/sys_helper.c | 6 -----
target/alpha/translate.c | 21 +++++-----------
target/riscv/csr.c | 3 ---
target/riscv/tcg/tcg-cpu.c | 3 ++-
20 files changed, 108 insertions(+), 108 deletions(-)
--
2.43.0
