Re: [PATCH V3 5/9] migration: cpr-exec-command parameter

[Steven Sistare]

On 9/11/2025 11:10 AM, Markus Armbruster wrote:

Steve Sistare <steven.sist...@oracle.com> writes:

Create the cpr-exec-command migration parameter, defined as a list of
strings.  It will be used for cpr-exec migration mode in a subsequent
patch, and contains forward references to cpr-exec mode in the qapi
doc.

No functional change, except that cpr-exec-command is shown by the
'info migrate' command.

Signed-off-by: Steve Sistare <steven.sist...@oracle.com>
---
  qapi/migration.json            | 21 ++++++++++++++++++---
  migration/migration-hmp-cmds.c | 25 +++++++++++++++++++++++++
  migration/options.c            | 14 ++++++++++++++
  hmp-commands.hx                |  2 +-
  4 files changed, 58 insertions(+), 4 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index 2387c21..ea410fd 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -924,6 +924,10 @@
  #     only has effect if the @mapped-ram capability is enabled.
  #     (Since 9.1)
  #
+# @cpr-exec-command: Command to start the new QEMU process when @mode
+#     is @cpr-exec.  The first list element is the program's filename,
+#     the remainder its arguments. (Since 10.2)

Please add a second space in ". (" for all three copies.

Sure.  Thanks for reviewing.

- Steve

+#
  # Features:
  #
  # @unstable: Members @x-checkpoint-delay and
@@ -950,7 +954,8 @@
             'vcpu-dirty-limit',
             'mode',
             'zero-page-detection',
-           'direct-io'] }
+           'direct-io',
+           'cpr-exec-command'] }

##

  # @MigrateSetParameters:
@@ -1105,6 +1110,10 @@
  #     only has effect if the @mapped-ram capability is enabled.
  #     (Since 9.1)
  #
+# @cpr-exec-command: Command to start the new QEMU process when @mode
+#     is @cpr-exec.  The first list element is the program's filename,
+#     the remainder its arguments. (Since 10.2)
+#
  # Features:
  #
  # @unstable: Members @x-checkpoint-delay and
@@ -1146,7 +1155,8 @@
              '*vcpu-dirty-limit': 'uint64',
              '*mode': 'MigMode',
              '*zero-page-detection': 'ZeroPageDetection',
-            '*direct-io': 'bool' } }
+            '*direct-io': 'bool',
+            '*cpr-exec-command': [ 'str' ]} }

##

  # @migrate-set-parameters:
@@ -1315,6 +1325,10 @@
  #     only has effect if the @mapped-ram capability is enabled.
  #     (Since 9.1)
  #
+# @cpr-exec-command: Command to start the new QEMU process when @mode
+#     is @cpr-exec.  The first list element is the program's filename,
+#     the remainder its arguments. (Since 10.2)
+#
  # Features:
  #
  # @unstable: Members @x-checkpoint-delay and
@@ -1353,7 +1367,8 @@
              '*vcpu-dirty-limit': 'uint64',
              '*mode': 'MigMode',
              '*zero-page-detection': 'ZeroPageDetection',
-            '*direct-io': 'bool' } }
+            '*direct-io': 'bool',
+            '*cpr-exec-command': [ 'str' ]} }

##

  # @query-migrate-parameters:

Acked-by: Markus Armbruster <arm...@redhat.com>


[...]