On Tue, Sep 02, 2025 at 12:30:06PM +0200, Richard Henderson wrote: > Hi Daniel, > > I'm still not keen on qmessage_context allocating a string. > > If we *did* allocate a string, it should be a GString so that we can > easily append to that. The only benefit I see from this is that we > would collect all of the output and it would reach stderr atomically. > > However, I think it's better to not collect the message and just > output the pieces. Something like the following. The names are > horrible and I didn't document the patches well.
I've posted a v3 of my series which incorporates the conceptual idea you show here. I managed to simplify it somewhat as I came to realize the qmessage_context code never needs to write to anything other than a "FILE *", because we always skip the context when writing to HMP. IOW, we could simply use fprintf() directly throughout With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
