On Sat, 30 Aug 2025 at 17:27, Richard Henderson <[email protected]> wrote: > > Separate current to unpriv and arm to core mmu conversions > into two separate functions. > > Reviewed-by: Pierrick Bouvier <[email protected]> > Signed-off-by: Richard Henderson <[email protected]> > --- > target/arm/tcg/translate-a64.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c > index 8c73f54e9a..ca1633540f 100644 > --- a/target/arm/tcg/translate-a64.c > +++ b/target/arm/tcg/translate-a64.c > @@ -93,7 +93,7 @@ void a64_translate_init(void) > } > > /* > - * Return the core mmu_idx to use for A64 load/store insns which > + * Return the full arm mmu_idx to use for A64 load/store insns which > * have a "unprivileged load/store" variant. Those insns access > * EL0 if executed from an EL which has control over EL0 (usually > * EL1) but behave like normal loads and stores if executed from > @@ -103,7 +103,7 @@ void a64_translate_init(void) > * normal encoding (in which case we will return the same > * thing as get_mem_index(). > */ > -static int get_a64_user_mem_index(DisasContext *s, bool unpriv) > +static ARMMMUIdx arm_user_mem_index(DisasContext *s, bool unpriv)
This function is named get_a64_user_mem_index() to indicate that it's the A64 logic, compared to get_a32_user_mem_index() in translate.c for the A32 logic. It seems a shame to lose the parallelism in the naming. -- PMM
