On 9/1/25 01:02, Philippe Mathieu-Daudé wrote:
On 18/8/25 20:37, Danny Canter wrote:
Howdy,
On macOS versions/SDKs before 26 you are correct, we had an invalid enum value for
HV_SYS_REG_MDCR_EL2 in the API, but the hv_vcpu_get/ set_sys_reg APIs work with this
value even though the
encoding is incorrect. The enum value has been remedied in 26+ (0xe089 as you pointed
out) and has been done in a backwards compatible way internally in the framework.
Thanks Danny!
Richard, should we guard the QEMU_BUILD_BUG_ON() macro with:
#if defined(MAC_OS_VERSION_26_0) && \
MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_26_0
?
That's one possibility. Another is to remap the one broken enum, since this fix is
described to be backward compatible.
r~
