On Mon, Sep 01, 2025 at 03:26:25PM +0200, Philippe Mathieu-Daudé wrote:
> Similarly to commit 64c1a544352 ("meson: Enable -Wvla") with
> variable length arrays, forbid alloca() uses on system code.
>
> There are few uses on ancient linux-user code, do not bother
> there.
This says you're not turning on -Walloca for linux-user, but....
> +if have_system
> + warn_flags += ['-Walloca']
> +endif
...surely this still turns on -Walloca for linux-user, if the build has
enabled multiple targets covering both system & user mode. ie a default
qemu build ?
> +
> # Set up C++ compiler flags
> qemu_cxxflags = []
> if 'cpp' in all_languages
> --
> 2.51.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
