Hi,
Michael Tokarev <[email protected]> writes:
[...]
>> diff --git a/tests/functional/x86_64/test_virtio_version.py
>> b/tests/functional/x86_64/test_virtio_version.py
>> index a5ea73237f..501545f655 100755
>> --- a/tests/functional/x86_64/test_virtio_version.py
>> +++ b/tests/functional/x86_64/test_virtio_version.py
>
>> @@ -68,7 +70,9 @@ def run_device(self, devtype, opts=None, machine='pc'):
>> """
>> Run QEMU with `-device DEVTYPE`, return device info from
>> `query-pci`
>> """
>> - with QEMUMachine(self.qemu_bin) as vm:
>> + with QEMUMachine(
>> + self.qemu_bin,
>> + base_temp_dir=os.environ.get('TMPDIR', '/var/tmp')) as vm:
>
> I don't think /var/tmp is a good choice here, - I'm a bit surprised it
> come from you when your OS doesn't have /var/tmp by default - shouldn't
> it be /tmp here?
I thought I'd make the smallest possible change compared the current
behavior, to maximize the chances this lands. The current behavior comes
from the default base_temp_dir value of QEMUMachine, which defaults to
/var/tmp.
If you prefer to fallback to just '/tmp' rather than '/var/tmp', that's
fine for me as well, though it could be surprising considering
QEMUMachine normally uses /var/tmp at run time.
--
Thanks,
Maxim
