On 8/29/25 00:42, Peter Maydell wrote:
On Thu, 28 Aug 2025 at 13:09, Richard Henderson
<[email protected]> wrote:
+/*
+ * Compare linux arch/x86/include/uapi/asm/ptrace.h (struct pt_regs) and
+ * arch/x86/include/asm/user_32.h (struct user_regs_struct).
+ * The structure layouts are identical; the user_regs_struct names are better.
+ */
Why do you think the user_regs_struct names are better?
"bx" suggests a 16-bit register, but these are 32-bit, right?
Mostly I really don't like xds etc.
Commit message should say something about why we're changing
the types (though clearly here the target-specific types are
more sensible than the host-specific ones).
Oops, yes. There are quite a lot of error across the various target_pt_regs structures
that we never caught because they were never used.
r~
