Hi , Thanks for the review and helpful suggestions. I will update the board documentation and provide a functional test case in the next version.
Best wishes, Yihao Fan 范艺豪 [email protected] Original: From：Peter Maydell <[email protected]>Date：2025-08-16 01:49:37(中国 (GMT+08:00))To：fanyihao<[email protected]>Cc：qemu-devel<[email protected]>Subject：Re: [PATCH v2 0/3] Add STM32F4 support and USART device modelOn Mon, 21 Jul 2025 at 21:11, <[email protected]> wrote: > > From: Yihao Fan <[email protected]> > > This patch series introduces basic support for the STM32F407 SoC and > a new STM32F4spark machine in QEMU, along with a USART device model. > > This series includes: > - A new SoC model (STM32F407) with initial integration. > - A board model called STM32F4spark to instantiate and test the SoC. > - A USART device implementation for STM32F4xx family. > > Signed-off-by: Yihao Fan <[email protected]> > > Yihao Fan (3): > Add-the-stm32f407-SoC > Add the STM32F4spark Machine > Add STM32F4xx USART device model > > MAINTAINERS | 16 ++ > hw/arm/Kconfig | 13 ++ > hw/arm/meson.build | 2 + > hw/arm/stm32f407_soc.c | 154 +++++++++++++++++++ > hw/arm/stm32f4spark.c | 48 ++++++ > hw/char/Kconfig | 3 + > hw/char/meson.build | 1 + > hw/char/stm32f4xx_usart.c | 236 ++++++++++++++++++++++++++++++ > include/hw/arm/stm32f407_soc.h | 47 ++++++ > include/hw/char/stm32f4xx_usart.h | 60 ++++++++ For a new board model there are a couple of things we'd like to see that aren't in this patchset: (1) Documentation. This lives in docs/system/arm/. For this board you want to add it to stm32.rst. (2) A test case in tests/functional/ -- generally this is something that downloads an image file from a public stable URL, runs it in QEMU and checks for some output from the guest on the UART indicating success. Lots of examples in this directory to see how to do it. thanks -- PMM
