On Fri, 8 Aug 2025 at 07:54, Mohamed Mediouni <[email protected]> wrote:
>
> Signed-off-by: Mohamed Mediouni <[email protected]>
>
> Reviewed-by: Pierrick Bouvier <[email protected]>
> +static void whpx_gicv3_put_cpu(CPUState *cpu_state, run_on_cpu_data arg)
> +{
> +}
> +
> +static void whpx_gicv3_put(GICv3State *s)
> +{
> + int ncpu;
> +
> + whpx_gicv3_check(s);
> +
> + for (ncpu = 0; ncpu < s->num_cpu; ncpu++) {
> + run_on_cpu_data data;
> + data.host_ptr = &s->cpu[ncpu];
> + run_on_cpu(s->cpu[ncpu].cpu, whpx_gicv3_put_cpu, data);
> + }
Why are we calling run_on_cpu() and telling it to do nothing?
Also, run_on_cpu() implicitly drops the big kernel lock --
I'm not sure that is valid to do from the pre-save/post-load
routines or in a reset handler.
thanks
-- PMM
