Reviewed-by: Kostiantyn Kostiuk <[email protected]>
On Thu, Aug 7, 2025 at 4:33 PM Denis V. Lunev via <[email protected]> wrote: > In this function we could have this variable not initialized. If this > could be acceptable on error, the variable could be left not initialized > f.e. as follows: > > void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset) > { > ... > if (mountpoints) { > ... > if (num_mount_points == 0) { > /* If there is no valid mount points, just exit. */ > goto out; > } > } > ... > if (!mountpoints) { > ... > if (num_fixed_drives == 0) { > goto out; /* If there is no fixed drive, just exit. */ > } > } > ... > } > > Stay on safe side, initialize the variable at the beginning. > > Signed-off-by: Denis V. Lunev <[email protected]> > CC: Kostiantyn Kostiuk <[email protected]> > CC: Michael Roth <[email protected]> > --- > qga/vss-win32.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qga/vss-win32.c b/qga/vss-win32.c > index f444a25a70..b272bfc782 100644 > --- a/qga/vss-win32.c > +++ b/qga/vss-win32.c > @@ -157,6 +157,8 @@ void qga_vss_fsfreeze(int *nr_volume, bool freeze, > .errp = errp, > }; > > + *nr_volume = 0; > + > g_assert(errp); /* requester.cpp requires it */ > func = (QGAVSSRequesterFunc)GetProcAddress(provider_lib, func_name); > if (!func) { > -- > 2.45.2 > > >
