Markus Armbruster <[email protected]> writes:

> Manos Pitsidianakis <[email protected]> writes:
>
>> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster <[email protected]> wrote:
>>>
>>> Signed-off-by: Markus Armbruster <[email protected]>
>>> ---
>>>  MAINTAINERS | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index f1bd69c3db..9c22e921e8 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt
>>>  F: docs/sphinx/
>>>  F: docs/_templates/
>>>  F: docs/devel/docs.rst
>>> +F: docs/devel/qapi-domain.rst
>>
>> Question: Does it matter if this is already covered by QAPI section
>> which has: "F: docs/devel/qapi*"?
>
> I'm adding it to the "Sphinx documentation configuration and build
> machinery" section as well.
>
> Before the patch:
>
>     $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst 
>     Markus Armbruster <[email protected]> (supporter:QAPI)
>     Michael Roth <[email protected]> (supporter:QAPI)
>     [email protected] (open list:All patches CC here)
>
> Afterwards:
>
>     $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst 
> --> John Snow <[email protected]> (maintainer:Sphinx documentat...)
> --> Peter Maydell <[email protected]> (maintainer:Sphinx documentat...)
>     Markus Armbruster <[email protected]> (supporter:QAPI)
>     Michael Roth <[email protected]> (supporter:QAPI)
>     [email protected] (open list:All patches CC here)
>
> Good, because it's John's baby, and he's maintaining it.
>
>> If not,
>>
>> Reviewed-by: Manos Pitsidianakis <[email protected]>
>
> Thank you!
>
> [...]

Amending the commit message:

    Section QAPI already covers it, and that's fine.  It's missing from
    "Sphinx documentation configuration and build machinery".  Add it
    there.


Reply via email to