On 28.07.2025 17:56, Eric Auger wrote:
Hi Michael,
Hi!
This commit added an imply ACPI_PCI to the PCI_EXPRESS_GENERIC_BRIDGE config in hw/pci-host/Kconfig: config PCI_EXPRESS_GENERIC_BRIDGE bool select PCI_EXPRESS -> selects PCI imply ACPI_PCI In hw/acpi/Kconfig we have: config ACPI_PCI bool depends on ACPI && PCI ACPI is selected by ACPI_HW_REDUCED config ACPI_HW_REDUCED bool select ACPI select ACPI_MEMORY_HOTPLUG select ACPI_NVDIMM so logically the ACPI && PCI dependencies for ACPI_PCI should be resolved. What do I miss?
I think it should be "select" not "imply", which seems to be stricter. With a devices file like I'm using - it looks like - only things which are selected gets enabled. But this commit brings hard dependency between the bridge device and ACPI_PCI, as demonstrated by my example. So when the bridge selects ACPI_PCI instead of implying it, whole thing works (I just verified it) I wonder why we build microvm-only executable in debian... Initially it was a small binary aimed at very fast startup and light runtime. But with time it grew quite a lot of things... Thanks, /mjt
