On Mon, 21 Jul 2025 18:22:28 +0100 <shiju.j...@huawei.com> wrote: > From: Shiju Jose <shiju.j...@huawei.com> > > Memory sparing is defined as a repair function that replaces a portion of > memory with a portion of functional memory at that same DPA. The > subclasses for this operation vary in terms of the scope of the sparing > being performed. The Cacheline sparing subclass refers to a sparing > action that can replace a full cacheline. Row sparing is provided as an > alternative to PPR sparing functions and its scope is that of a single > DDR row. Bank sparing allows an entire bank to be replaced. Rank sparing > is defined as an operation in which an entire DDR rank is replaced. > > Memory sparing maintenance operations may be supported by CXL devices > that implement CXL.mem protocol. A sparing maintenance operation requests > the CXL device to perform a repair operation on its media. > For example, a CXL device with DRAM components that support memory sparing > features may implement sparing Maintenance operations. > > The host may issue a query command by setting Query Resources flag in the > Input Payload (CXL Spec 3.2 Table 8-120) to determine availability of > sparing resources for a given address. In response to a query request, > the device shall report the resource availability by producing the Memory > Sparing Event Record (CXL Spec 3.2 Table 8-60) in which the Channel, Rank, > Nibble Mask, Bank Group, Bank, Row, Column, Sub-Channel fields are a copy > of the values specified in the request. > > During the execution of a sparing maintenance operation, a CXL memory > device: > - May or may not retain data > - May or may not be able to process CXL.mem requests correctly. > These CXL memory device capabilities are specified by restriction flags > in the memory sparing feature readable attributes. > > When a CXL device identifies error on a memory component, the device > may inform the host about the need for a memory sparing maintenance > operation by using DRAM event record, where the 'maintenance needed' flag > may set. The event record contains some of the DPA, Channel, Rank, > Nibble Mask, Bank Group, Bank, Row, Column, Sub-Channel fields that > should be repaired. The userspace tool requests for maintenance operation > if the 'maintenance needed' flag set in the CXL DRAM error record. > > CXL spec 3.2 section 8.2.10.7.2.3 describes the memory sparing feature > discovery and configuration. > > CXL spec 3.2 section 8.2.10.7.1.4 describes the device's memory sparing > maintenance operation feature. > > Add emulation for CXL memory device memory sparing control feature > and memory sparing maintenance operation command. > > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> > Signed-off-by: Shiju Jose <shiju.j...@huawei.com>
> + } else if (qemu_uuid_is_equal(&hdr->uuid, &rank_sparing_uuid)) { > + CXLMemSparingSetFeature *mem_sparing_set_feature = (void > *)payload_in; > + CXLMemSparingWriteAttrs *mem_sparing_write_attrs = > + &mem_sparing_set_feature->feat_data; > + > + if (hdr->version != CXL_MEMDEV_SPARING_SET_FEATURE_VERSION) { > + return CXL_MBOX_UNSUPPORTED; > + } > + > + memcpy((uint8_t *)&ct3d->rank_sparing_wr_attrs + hdr->offset, > + mem_sparing_write_attrs, > + bytes_to_copy); Trivial but no need for the wrap. There were some of these in previous patch as well. > + set_feat_info->data_size += bytes_to_copy; > + > + if (data_transfer_flag == CXL_SET_FEATURE_FLAG_FULL_DATA_TRANSFER || > + data_transfer_flag == CXL_SET_FEATURE_FLAG_FINISH_DATA_TRANSFER) > { > + ct3d->rank_sparing_attrs.op_mode = > + ct3d->rank_sparing_wr_attrs.op_mode; > + }