On Thu, Jul 24, 2025 at 4:00 PM Hanna Czenczek <hre...@redhat.com> wrote:
>
> Failing to stop logging in a vhost device is not exactly fatal. We can
> log such an error, but there is no need to abort the whole qemu process
> because of it.
>
> Signed-off-by: Hanna Czenczek <hre...@redhat.com>
> ---
> hw/virtio/vhost.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 05ad5de629..6557c58d12 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1122,7 +1122,8 @@ static void vhost_log_global_stop(MemoryListener
> *listener)
>
> r = vhost_migration_log(listener, false);
> if (r < 0) {
> - abort();
> + /* Not fatal, so report it, but take no further action */
> + warn_report("vhost: Failed to stop logging");
> }
> }
>
> --
> 2.50.1
>
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>
--
Manos Pitsidianakis
Emulation and Virtualization Engineer at Linaro Ltd
