Re: [PATCH v2 5/6] hw/i386/amd_iommu: Support MMIO writes to the status register

[Philippe Mathieu-Daudé]

On 24/7/25 08:47, Sairaj Kodilkar wrote:

Support the writes to the status register so that guest can reset the
EventOverflow, EventLogInt, ComWaitIntr, etc bits after servicing the
respective interrupt.

Signed-off-by: Sairaj Kodilkar <sarun...@amd.com>
Reviewed-by: Vasant Hegde <vasant.he...@amd.com>
---
  hw/i386/amd_iommu.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index bbffd07b4e48..7c2fa80d14ff 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -850,6 +850,9 @@ static void amdvi_mmio_write(void *opaque, hwaddr addr, 
uint64_t val,
          amdvi_mmio_reg_write(s, size, val, addr);
          amdvi_handle_pprtail_write(s);
          break;
+    case AMDVI_MMIO_STATUS:
+        amdvi_mmio_reg_write(s, size, val, addr);
+        break;

Should we add:

        default:
            g_assert_not_reached();

to catch unimplemented cases?

      }
  }