On 7/23/25 18:15, Collin Walling wrote: > On 7/11/25 17:10, Zhuoying Cai wrote: >> DIAG 320 subcode 1 provides information needed to determine >> the amount of storage to store one or more certificates. >> >> The subcode value is denoted by setting the left-most bit >> of an 8-byte field. > > This is general DIAG knowledge. Remove this sentence. > >> >> The verification-certificate-storage-size block (VCSSB) contains >> the output data when the operation completes successfully. >> > > Please add more detail describing where the data that the VCSSB gets > filled with comes from (s390 cert store), how this subcode is useful > (e.g. getting num of certs, knowing how much space may need to be > allocated to store a cert). > > There are some #defines for the VCE (cert entries) and VCB (subcode 2 > data structure). Please elaborate on them in the commit message. >
This may get satisfied when merging in the relevant documentation from patch 28, but it's still good practice to summarize things in the commit message. -- Regards, Collin
