On Tue, Jul 22, 2025 at 08:00:00AM -0400, Brian Song wrote:
> On 7/21/25 9:51 AM, Bernd Schubert wrote:
> >> + struct fuse_in_header *in_hdr = (struct fuse_in_header *)&rrh->in_out;
> >> + opcode = in_hdr->opcode;
> >> + req_id = in_hdr->unique;
> >> +
> >> + ent->req_commit_id = ent_in_out->commit_id;
> >> +
> >> + if (unlikely(ent->req_commit_id == 0)) {
> >> + /*
> >> + * If this happens kernel will not find the response - it will
> >> + * be stuck forever - better to abort immediately.
> >> + */
> >> + error_report("If this happens kernel will not find the response"
> >> + " - it will be stuck forever - better to abort immediately.");
> >
> > Dunno about qemu style, but isn't it better to keep the string in a single
> > line to make it greppable?
> >
>
> The actual log output doesn’t include any line breaks. I just broke the
> line in the code to keep it under 80 characters per line.QEMU coding style is stricter about 80 characters per line. Linux allows long error message strings on a line so it is easier to grep for them in the source code. I think it's just a difference in coding style and splitting strings is generally how QEMU code does it. Stefan
signature.asc
Description: PGP signature
