On 17/07/2025 11:28, Peter Maydell wrote:
On Tue, 15 Jul 2025 at 05:42, Jason Wang <jasow...@redhat.com> wrote:
From: Laurent Vivier <lviv...@redhat.com>
This commit introduces support for passt as a new network backend.
passt is an unprivileged, user-mode networking solution that provides
connectivity for virtual machines by launching an external helper process.
The implementation reuses the generic stream data handling logic. It
launches the passt binary using GSubprocess, passing it a file
descriptor from a socketpair() for communication. QEMU connects to
the other end of the socket pair to establish the network data stream.
The PID of the passt daemon is tracked via a temporary file to
ensure it is terminated when QEMU exits.
Hi; Coverity points out some potential issues with this code:
+static void net_passt_cleanup(NetClientState *nc)
+{
+ NetPasstState *s = DO_UPCAST(NetPasstState, data.nc, nc);
+
+ kill(s->pid, SIGTERM);
CID 1612369: we don't check the return value from kill().
Do we want to check it or "(void)kill()" is enough to fix this?
Thanks,
Laurent
