On Fri, 11 Jul 2025 at 11:45, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 10/7/25 16:33, Peter Maydell wrote: > > This has reintroduced CID 1547782 (unreachable code). > > > > We can't get to this point, so why are we trying to call a > > function here ? This is not a place where the thread can exit. > > The goal is to unify accelerators vcpu thread logic and > eventually remove AccelOpsClass::create_vcpu_thread(), superseded > by AccelOpsClass::cpu_thread_routine(). I couldn't finish RR for > 10.1 but squeezed this patch in. Let's revert it, and I'll > re-commit it later.
When you do have a need for it, note that rcu_unregister_thread() is probably not the only call you need here -- see commit da7510b720591. We used to also have an equally unreachable rcu_remove_force_rcu_notifier() call. thanks -- PMM