> Revived a 2023 patch from Fabiano Rosas: > > https://lore.kernel.org/qemu-devel/20230113140419.4013-7-faro...@suse.de/ > > which was dropped between patch set v3 and v4 without comment. > Prune the headers from helper.c which are no longer required. > > Cc: Fabiano Rosas <faro...@suse.de> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/internals.h | 1 + > target/arm/cpregs.c | 9274 ++++++++++++++++++++++++++++++++++++++++ > target/arm/helper.c | 9264 +-------------------------------------- > target/arm/meson.build | 2 + > 4 files changed, 9278 insertions(+), 9263 deletions(-) > create mode 100644 target/arm/cpregs.c
Rather than this, I would prefer that we continue down the path of identifying specific pieces of functionality to split out of helper.c, as we have already done with for example debug_helper.c and tlb-insns.c. The PMU is probably the next obvious chunk to split out like that. This patch is also way too large -- it was practically unmanageable to reply to in my email client. That also seems to me like an argument for doing the split in smaller chunks. -- PMM
