On Thu, Jul 03, 2025 at 05:17:31PM +0200, Cédric Le Goater wrote:
> On 7/3/25 16:42, Ed Tanous wrote:
> > To support the newly added gb200 machine, add appropriate tests.
> >
> > Signed-off-by: Ed Tanous <etan...@nvidia.com>
> > ---
> > tests/functional/aspeed.py | 9 +++++--
> > tests/functional/meson.build | 2 ++
> > .../test_arm_aspeed_gb200nvl_bmc.py | 26 +++++++++++++++++++
> > 3 files changed, 35 insertions(+), 2 deletions(-)
> > create mode 100755 tests/functional/test_arm_aspeed_gb200nvl_bmc.py
> >
> > diff --git a/tests/functional/aspeed.py b/tests/functional/aspeed.py
> > index 7a40d5dda7..b131703c52 100644
> > --- a/tests/functional/aspeed.py
> > +++ b/tests/functional/aspeed.py
> > @@ -8,8 +8,13 @@
> > class AspeedTest(LinuxKernelTest):
> > def do_test_arm_aspeed_openbmc(self, machine, image, uboot='2019.04',
> > - cpu_id='0x0', soc='AST2500 rev A1'):
> > - hostname = machine.removesuffix('-bmc')
> > + cpu_id='0x0', soc='AST2500 rev A1',
> > + image_hostname=None):
> > + # Allow for the image hostname to not end in "-bmc"
> > + if image_hostname is not None:
> > + hostname = image_hostname
> > + else:
> > + hostname = machine.removesuffix('-bmc')
>
>
> This change belongs to another patch and it doesn't seem that
> this series needs it. Does it ?
I Should've been made more clear in the commit message, but yes, this is
required because the hostname of this system is gb200nvl-obmc, so
removing the postfix of -bmc fails, and the test fails because of it.
This code allows adding an opt-in param to handle the different string.
I can break it out into its own commit if that's an issue.
>
>
> Thanks,
>
> C.
>
>
>
> > self.set_machine(machine)
> > self.vm.set_console()
> > diff --git a/tests/functional/meson.build b/tests/functional/meson.build
> > index 85158562a2..d2864543a5 100644
> > --- a/tests/functional/meson.build
> > +++ b/tests/functional/meson.build
> > @@ -32,6 +32,7 @@ test_timeouts = {
> > 'arm_aspeed_ast2500' : 720,
> > 'arm_aspeed_ast2600' : 1200,
> > 'arm_aspeed_bletchley' : 480,
> > + 'arm_aspeed_gb200nvl_bmc' : 480,
> > 'arm_aspeed_rainier' : 480,
> > 'arm_bpim2u' : 500,
> > 'arm_collie' : 180,
> > @@ -126,6 +127,7 @@ tests_arm_system_thorough = [
> > 'arm_aspeed_ast2500',
> > 'arm_aspeed_ast2600',
> > 'arm_aspeed_bletchley',
> > + 'arm_aspeed_gb200nvl_bmc',
> > 'arm_aspeed_rainier',
> > 'arm_bpim2u',
> > 'arm_canona1100',
> > diff --git a/tests/functional/test_arm_aspeed_gb200nvl_bmc.py
> > b/tests/functional/test_arm_aspeed_gb200nvl_bmc.py
> > new file mode 100755
> > index 0000000000..8e8e3f05c1
> > --- /dev/null
> > +++ b/tests/functional/test_arm_aspeed_gb200nvl_bmc.py
> > @@ -0,0 +1,26 @@
> > +#!/usr/bin/env python3
> > +#
> > +# Functional test that boots the ASPEED machines
> > +#
> > +# SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +from qemu_test import Asset
> > +from aspeed import AspeedTest
> > +
> > +
> > +class GB200Machine(AspeedTest):
> > +
> > + ASSET_GB200_FLASH = Asset(
> > +
> > 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
> > + 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
> > +
> > + def test_arm_aspeed_gb200_openbmc(self):
> > + image_path = self.uncompress(self.ASSET_GB200_FLASH)
> > +
> > + self.do_test_arm_aspeed_openbmc('gb200nvl-bmc', image=image_path,
> > + uboot='2019.04', cpu_id='0xf00',
> > + soc='AST2600 rev A3',
> > + image_hostname='gb200nvl-obmc')
> > +
> > +if __name__ == '__main__':
> > + AspeedTest.main()
>
