On Thu, 3 Jul 2025 09:46:32 +0100
Shameer Kolothum <shameerali.kolothum.th...@huawei.com> wrote:
> Commit d6afe18b7242 ("hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables
> when its=off") moved ITS group node generation under the its=on condition.
> However, it still creates rc_its_idmaps unconditionally, which results in
> duplicate ID mappings in the IORT table.
>
> Fixes:d6afe18b7242 ("hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables
> when its=off")
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.th...@huawei.com>
As per discussion offlist. Why are we not seeing a table change with this?
Seems that we don't have a test for this case (yet) - later in this series
there is one and I guess Gustavo knew that was coming!
Anyhow, the patch looks good to me.
Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> ---
> hw/arm/virt-acpi-build.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index cd90c47976..724fad5ffa 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -329,12 +329,6 @@ build_iort(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> /* Sort the smmu idmap by input_base */
> g_array_sort(rc_smmu_idmaps, iort_idmap_compare);
>
> - /*
> - * Knowing the ID ranges from the RC to the SMMU, it's possible to
> - * determine the ID ranges from RC that are directed to the ITS.
> - */
> - create_rc_its_idmaps(rc_its_idmaps, rc_smmu_idmaps);
> -
> nb_nodes = 2; /* RC and SMMUv3 */
> rc_mapping_count = rc_smmu_idmaps->len;
>
