Everytime I look at the flow of how x86 cpu is initialized, I get confused by the name of host_cpu_instance_init() and host_cpu_max_instance_init(). They look like related to "-cpu host" and the .instance_init() callback of "-cpu host".
However, host_cpu_instance_init() even has noting to do with "-cpu host". So patch 1, to rename host_cpu_instance_init(). I also want to rename host_cpu_max_instance_init(), but I cannot think of a new better name so I just leave it as-is. Patch 2 is the cleanup found when I look at host-cpu.c Note, this series is based on my another cleanup [1]. It might be able to apply cleanly on master with [1]. [1] https://lore.kernel.org/qemu-devel/20250630080610.3151956-1-xiaoyao...@intel.com/ Xiaoyao Li (2): i386/cpu: Rename host_cpu_instance_init() to apply_host_vendor() i386/cpu: Move the implementation of is_host_cpu_intel() host-cpu.c target/i386/host-cpu.c | 21 +++++++++++++-------- target/i386/host-cpu.h | 3 ++- target/i386/hvf/hvf-cpu.c | 5 ++++- target/i386/kvm/kvm-cpu.c | 4 ++-- target/i386/kvm/vmsr_energy.c | 9 --------- target/i386/kvm/vmsr_energy.h | 1 - 6 files changed, 21 insertions(+), 22 deletions(-) -- 2.43.0
