Hi Daniel,
On 6/25/25 11:23 AM, Daniel P. Berrangé wrote:
> On Wed, Jun 25, 2025 at 11:16:22AM +0200, Eric Auger wrote:
>> Hi Connie,
>>
>> On 6/17/25 5:45 PM, Cornelia Huck wrote:
>>> On Tue, Jun 17 2025, Cornelia Huck <coh...@redhat.com> wrote:
>>>
>>>> diff --git a/scripts/arm-gen-cpu-sysregs-header.awk
>>>> b/scripts/arm-gen-cpu-sysregs-header.awk
>>>> new file mode 100755
>>>> index 000000000000..f92bbbafa727
>>>> --- /dev/null
>>>> +++ b/scripts/arm-gen-cpu-sysregs-header.awk
>>>> @@ -0,0 +1,37 @@
>>>> +#!/bin/awk -f
>>>> +# SPDX-License-Identifier: GPL-2.0-or-later
>>>> +# arm-gen-cpu-sysregs-header.awk: arm64 sysreg header include generator
>>>> +#
>>>> +# Usage: awk -f arm-gen-cpu-sysregs-header.awk
>>>> $LINUX_PATH/arch/arm64/tools/sysreg
>>>> +
>>>> +BEGIN {
>>>> + print "/* SPDX-License-Identifier: GPL-2.0-or-later */"
>>> FWIW, checkpatch.pl chokes on this:
>>>
>>> ^* matches null string many times in regex; marked by <-- HERE in m/^* <--
>>> HERE /"$/ at scripts/checkpatch.pl line 1389.
>>> ERROR: Saw unacceptable licenses '*/"', valid choices for QEMU are:
>>> GPL-2.0-or-later
>>> GPL-2.0-only
>>> LGPL-2.1-only
>>> LGPL-2.1-or-later
>>> BSD-2-Clause
>>> BSD-3-Clause
>>> MIT
>>> total: 1 errors, 0 warnings, 76 lines checked
>> so don't we need to improve checkpatch.pl to silence this error?
> Its regex gets confused by the trailing " after the comment end. We
> could fix it, but ignoring the error is also valid as this is a
> highly unusual file that's not likely to be common through our
> source tree.
Makes sense. We are good then.
Thanks!
Eric
>
>
> With regards,
> Daniel
