Hi Jonathan, On 6/20/25 11:38 AM, Jonathan Cameron wrote: > On Mon, 16 Jun 2025 11:46:48 +0200 > Eric Auger <eric.au...@redhat.com> wrote: > >> The bus will be needed on ged realize for acpi pci hp setup. >> >> Signed-off-by: Eric Auger <eric.au...@redhat.com> > I guess doing this in separate patches for previous and this one > maybe makes it easier to backport the previous if someone just wants > to enable this on a different arch. Otherwise I'd have smashed them > together.
for me it is also a matter of maintainership/reviewer role separataion, virt and ged being maintained/reviewed by different people. So if you don't mind, I will keep it separate all the more so I collected R-b's on each ;-) Eric > > Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> >> --- >> hw/arm/virt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index 08bd808499..2f34877716 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -696,6 +696,7 @@ static inline DeviceState >> *create_acpi_ged(VirtMachineState *vms) >> >> dev = qdev_new(TYPE_ACPI_GED); >> qdev_prop_set_uint32(dev, "ged-event", event); >> + object_property_set_link(OBJECT(dev), "bus", OBJECT(vms->bus), >> &error_abort); >> sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); >> >> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, >> vms->memmap[VIRT_ACPI_GED].base);
