On Sun, 22 Jun 2025 at 00:55, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
>  include/tcg/tcg-op-gvec-common.h |  3 ++
>  tcg/tcg-op-gvec.c                | 85 ++++++++++++++++++++------------
>  2 files changed, 56 insertions(+), 32 deletions(-)
>
> diff --git a/include/tcg/tcg-op-gvec-common.h 
> b/include/tcg/tcg-op-gvec-common.h
> index 65553f5f97..877871c101 100644
> --- a/include/tcg/tcg-op-gvec-common.h
> +++ b/include/tcg/tcg-op-gvec-common.h
> @@ -227,6 +227,9 @@ typedef struct {
>      bool prefer_i64;
>  } GVecGen4i;
>
> +void tcg_gen_gvec_2_var(TCGv_ptr dbase, uint32_t dofs,
> +                        TCGv_ptr abase, uint32_t aofs,
> +                        uint32_t oprsz, uint32_t maxsz, const GVecGen2 *);
>  void tcg_gen_gvec_2(uint32_t dofs, uint32_t aofs,
>                      uint32_t oprsz, uint32_t maxsz, const GVecGen2 *);
>  void tcg_gen_gvec_2i(uint32_t dofs, uint32_t aofs, uint32_t oprsz,

I know the existing tcg_gen_gvec_{2,3,4}{,i,s} don't have any
comments documenting them, but is it possible to add something
here? Part of the reason I find the TCG vector handling a bit
inscrutable as somebody who mostly sticks to target/ code is
that the interface between the target/ code and the TCG
core code is not really documented.

Either way,
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

thanks
-- PMM

Reply via email to