Hi Gustavo,
On 6/16/25 3:18 PM, Gustavo Romero wrote:
> Because 'tcg_its' in the machine instance is set based on the machine
> class’s negated variable 'no_tcg_its', 'tcg_its' is the opposite of
> 'no_tcg_its' and hence the code in question can be simplified as:
> tcg_its = !no_tcg_its.
>
> Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
> ---
> hw/arm/virt.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 9a6cd085a3..42a63a523e 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -3337,12 +3337,8 @@ static void virt_instance_init(Object *obj)
>
> /* Default allows ITS instantiation */
> vms->its = true;
> -
> - if (vmc->no_tcg_its) {
> - vms->tcg_its = false;
> - } else {
> - vms->tcg_its = true;
> - }
> + /* Allow ITS emulation if the machine version supports it. */
remove "."?
besides
Reviewed-by: Eric Auger <eric.au...@redhat.com>
> + vms->tcg_its = !vmc->no_tcg_its;
>
> /* Default disallows iommu instantiation */
> vms->iommu = VIRT_IOMMU_NONE;
