On 03.05.2012, at 15:34, Alexander Graf wrote: > > On 03.05.2012, at 14:32, Anthony Liguori wrote: > >> On 05/03/2012 04:07 AM, Alexander Graf wrote: >>> >>> On 03.05.2012, at 11:05, Paolo Bonzini wrote: >>> >>>> >>>>>> The usual old fix was to not even compile them in. Why are they in >>>>>> the alias list in the s390 build now? >>>>> >>>>> Because the alias list is in target-independent code. >>>>> >>>>> The old fix was brittle anyway, it dependent on the fact that >>>>> virtio-blk-pci was not part of libhw. A similar trick broke for >>>>> cirrus-vga when it became part of libhw. >>>>> >>>>> Christian fix is correct. >>>> >>>> Uhm, Christian fix would have the same problem actually if >>>> virtio-*-pci were to be moved in libhw. IIRC I proposed the >>>> same change on review and Anthony nacked it on these grounds. >>>> You could move the alias list to target-dependent code, though. >>> >>> Can't we just make the virtio-*-pci variants fail instantiation and based >>> on that search the list on? >> >> No, but you could do: > > Ah, nice. Here is a fixed (and tested) version:
Ping? What do we do about this one? Alex
